Initial productionization #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adwk67
approved these changes
Nov 28, 2024
Member
adwk67
left a comment
adwk67
left a comment
There was a problem hiding this comment.
Very nice! Tested this with the associated zookeeper draft PR and logs appear in the terminal log window and also in json format.
adwk67
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes to make it more suitable for integrating into the SDP, see stackabletech/issues#527
For an example integration, see stackabletech/zookeeper-operator#881
Fixes #4, fixes #5, fixes #6, fixes #7
The output now looks something like this in the terminal log:
or like this in a vector target like OpenSearch:
The JSON output is preserved, and can be enabled with the
--outputoption. Logs are dumped as collection happens, which should also help users better understand why/whether it's running slow.